Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(supportability): update etcd pagination fetch method #426

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Abhinandan-Purkait
Copy link
Member

Changes in the PR.

  • Updates the control-plane submodule.
  • Uses the get_values_paged_all method to compute range.

Copy link
Contributor

@chriswldenyer chriswldenyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 1, 2024
426: feat(supportability): update etcd pagination fetch method r=Abhinandan-Purkait a=Abhinandan-Purkait

#### Changes in the PR.

- Updates the control-plane submodule.
- Uses the `get_values_paged_all` method to compute range.

Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@bors-openebs-mayastor
Copy link
Contributor

Timed out.

@tiagolobocastro
Copy link
Contributor

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 1, 2024
426: feat(supportability): update etcd pagination fetch method r=tiagolobocastro a=Abhinandan-Purkait

#### Changes in the PR.

- Updates the control-plane submodule.
- Uses the `get_values_paged_all` method to compute range.

Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@bors-openebs-mayastor
Copy link
Contributor

Timed out.

@abhilashshetty04
Copy link
Contributor

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 4, 2024
@bors-openebs-mayastor
Copy link
Contributor

try

Timed out.

@abhilashshetty04
Copy link
Contributor

bors ping

@bors-openebs-mayastor
Copy link
Contributor

pong

@Abhinandan-Purkait
Copy link
Member Author

bors try-

@Abhinandan-Purkait
Copy link
Member Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 4, 2024
@bors-openebs-mayastor
Copy link
Contributor

try

Build failed:

@tiagolobocastro
Copy link
Contributor

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 4, 2024
426: feat(supportability): update etcd pagination fetch method r=tiagolobocastro a=Abhinandan-Purkait

#### Changes in the PR.

- Updates the control-plane submodule.
- Uses the `get_values_paged_all` method to compute range.

Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Already running a review

@Abhinandan-Purkait
Copy link
Member Author

bors cancel

@bors-openebs-mayastor
Copy link
Contributor

Canceled.

@Abhinandan-Purkait
Copy link
Member Author

bors merge

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 4, 2024
426: feat(supportability): update etcd pagination fetch method r=Abhinandan-Purkait a=Abhinandan-Purkait

#### Changes in the PR.

- Updates the control-plane submodule.
- Uses the `get_values_paged_all` method to compute range.

Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@bors-openebs-mayastor
Copy link
Contributor

Timed out.

@tiagolobocastro
Copy link
Contributor

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 5, 2024
@bors-openebs-mayastor
Copy link
Contributor

try

Build succeeded:

@Abhinandan-Purkait
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit adf25dd into develop Mar 5, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the fix_etcd branch March 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants